Maor Lipchuk has posted comments on this change.
Change subject: engine, dao: Introduce ISCSI Bond entity, tables and dao
......................................................................
Patch Set 3:
(2 comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/IscsiBond.java
Line 50: public void setStoragePoolId(Guid storagePoolId) {
Line 51: this.storagePoolId = storagePoolId;
Line 52: }
Line 53:
Line 54: @Size(min = 1, max = 50, message =
"VALIDATION.ISCSI_BOND.NAME.INVALID.LENGTH",
In that case you should also use a specific message for the description field
if the max size is bigger then GENERAL_MAX_SIZE...
Line 55: groups = { CreateEntity.class, UpdateEntity.class })
Line 56: @ValidI18NName(message =
"VALIDATION.ISCSI_BOND.NAME.INVALID.CHARACTER",
Line 57: groups = { CreateEntity.class, UpdateEntity.class })
Line 58: public String getName() {
....................................................
File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
Line 1087:
Line 1088: SCHEDULING_ALL_HOSTS_FILTERED_OUT=Cannot ${action} ${type}. There is
no host that satisfies current scheduling constraints. See bellow for details:
Line 1089: SCHEDULING_HOST_FILTERED_REASON=The host ${hostName} did not satisfy
${filterType} filter ${filterName}.
Line 1090: VAR__FILTERTYPE__EXTERNAL=$filterType external
Line 1091: VAR__FILTERTYPE__INTERNAL=$filterType internal
I'm not sure I follow, if you want to use those message you will have to add
them to the AppErrors.java. If you want to perform them in the user portal or
in tests you will have to add them to the other AppErrors.properties files
Line 1092: POWER_MANAGEMENT_ACTION_ON_ENTITY_ALREADY_IN_PROGRESS=Cannot perform
${action}. Another power management action is already in progress.
Line 1093:
Line 1094: VALIDATION.ISCSI_BOND.NAME.INVALID.CHARACTER=Iscsi Bond name must be
formed from alpha-numeric characters or "-_."
Line 1095: VALIDATION.ISCSI_BOND.NAME.INVALID.LENGTH=Length of {0} has to be
between {1} and {2}
--
To view, visit http://gerrit.ovirt.org/22951
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I12313c02810a2f0e75016bdd78b44da43f2154d4
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
