Allon Mureinik has uploaded a new change for review. Change subject: core: No param dependency in AsyncTasks' equals ......................................................................
core: No param dependency in AsyncTasks' equals AsyncTasks' equals(Object) and hashCode() rely on VdcActionParametersBase's equals(Object) and hashCode() (respectively), which are known to be broken (as the inheriting classes do not override them). These methods were removed from VdcActionParametersBase in patch 2d884006f356ca95c6b43a509aa809cc3647552c, which neglected to remove the dependency from AsyncTasks, breaking the DAO test suite. This patch remedies that mistake. Change-Id: Ib3b8ce8f32442732b9a529b2d354803ece1b55f4 Signed-off-by: Allon Mureinik <[email protected]> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/AsyncTasks.java 1 file changed, 0 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/81/23181/1 diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/AsyncTasks.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/AsyncTasks.java index c7c0252..87c67e2 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/AsyncTasks.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/AsyncTasks.java @@ -184,7 +184,6 @@ results = prime * results + ((stepId == null) ? 0 : stepId.hashCode()); results = prime * results + ((commandId == null) ? 0 : commandId.hashCode()); results = prime * results + ((rootCommandId == null) ? 0 : rootCommandId.hashCode()); - results = prime * results + ((actionParameters == null) ? 0 : actionParameters.hashCode()); results = prime * results + ((actionType == null) ? 0 : actionType.hashCode()); results = prime * results + ((result == null) ? 0 : result.hashCode()); results = prime * results + ((status == null) ? 0 : status.hashCode()); @@ -211,7 +210,6 @@ && ObjectUtils.objectsEqual(stepId, other.stepId) && ObjectUtils.objectsEqual(commandId, other.commandId) && ObjectUtils.objectsEqual(rootCommandId, other.rootCommandId) - && ObjectUtils.objectsEqual(actionParameters, other.actionParameters) && actionType == other.actionType && result == other.result && status == other.status -- To view, visit http://gerrit.ovirt.org/23181 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib3b8ce8f32442732b9a529b2d354803ece1b55f4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
