Kanagaraj M has uploaded a new change for review. Change subject: webadmin: fix rendering issue in DetailsRenderer ......................................................................
webadmin: fix rendering issue in DetailsRenderer Widgets like MemorySizeTextBoxLabel are now inherited from ValueBoxBase instead of ValueLabel. ValueBoxBase uses input-text html element to display the data as opposed to div used by ValueLabel. So instead of taking the innerHtml from these fields, DetailsRenderer will use getValue() to get the data. Change-Id: I244819f17be801f8ba8c5c709e5127bd66567c81 Bug-Url: https://bugzilla.redhat.com/1049892 Signed-off-by: Kanagaraj M <[email protected]> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/renderer/DetailsRenderer.java 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/14/23214/1 diff --git a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/renderer/DetailsRenderer.java b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/renderer/DetailsRenderer.java index 8cc2b31..d012f44 100644 --- a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/renderer/DetailsRenderer.java +++ b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/renderer/DetailsRenderer.java @@ -21,7 +21,7 @@ StringBuilder formattedStr = new StringBuilder(); for (int i = 0; i < widgets.size(); i++) { - formattedStr.append(widgets.get(i).getElement().getInnerHTML()).append(" ").append(delimiters[i]); //$NON-NLS-1$ + formattedStr.append(widgets.get(i).getValue()).append(" ").append(delimiters[i]); //$NON-NLS-1$ if (i < widgets.size() - 1) { formattedStr.append(", "); //$NON-NLS-1$ } -- To view, visit http://gerrit.ovirt.org/23214 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I244819f17be801f8ba8c5c709e5127bd66567c81 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
