Moti Asayag has posted comments on this change. Change subject: engine: Extract nic labels check into a method ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/23193/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/UnlabelNicCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/UnlabelNicCommand.java: Line 58: if (getNic() == null) { Line 59: return failCanDoAction(VdcBllMessages.HOST_NETWORK_INTERFACE_NOT_EXIST); Line 60: } Line 61: Line 62: if (NetworkUtils.isLabeled(getNic()) || !getNic().getLabels().contains(getLabel())) { > Should be ! Done Line 63: return failCanDoAction(VdcBllMessages.INTERFACE_NOT_LABELED); Line 64: } Line 65: Line 66: return true; -- To view, visit http://gerrit.ovirt.org/23193 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icef35e6a0f8a1334e871d2bdc718fb0eb1b9ece6 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
