Piotr Kliczewski has posted comments on this change. Change subject: tools: This change introduces the EventSubscribersProvider interface. ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/23154/4/backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/subscribers/EventSubscribersProvider.java File backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/subscribers/EventSubscribersProvider.java: Line 4: import org.ovirt.engine.core.common.businessentities.AuditLogEventSubscriber; Line 5: Line 6: import java.util.Collection; Line 7: Line 8: public interface EventSubscribersProvider { It is good to have javadocs at the interface level. Line 9: Line 10: Collection<AuditLogEventSubscriber> provide(); Line 11: -- To view, visit http://gerrit.ovirt.org/23154 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id863557f3902ab18f5dac7a822ca55ad0c96dda5 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <[email protected]> Gerrit-Reviewer: Liran Zelkha <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
