Roy Golan has posted comments on this change. Change subject: core: block virtio-scsi for unsupported OSes ......................................................................
Patch Set 1: (1 comment) minor inside add a can do to changeVmCluster http://gerrit.ovirt.org/#/c/22648/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java: Line 406: Version clusterVersion, Line 407: List<String> reasons) { Line 408: boolean result = VmValidationUtils.isOsSupportedForVirtIoScsi(osId, clusterVersion); Line 409: if (!result) { Line 410: reasons.add(VdcBllMessages.ACTION_TYPE_FAILED_ILLEGAL_OS_TYPE_IS_DOES_NOT_SUPPORT_VIRTIO_SCSI.toString()); name() and not toString() Line 411: } Line 412: return result; Line 413: } Line 414: -- To view, visit http://gerrit.ovirt.org/22648 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id9907d35b53c0447662bc638146c4c61ac5cce8a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Vitor de Lima <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
