Michal Skrivanek has posted comments on this change. Change subject: frontend: SPICE ActiveX plugin IE 11 workaround ......................................................................
Patch Set 1: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/23280/1/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/SpicePluginImpl.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/SpicePluginImpl.java: Line 87: var container = $wnd.document.createElement("div"); Line 88: container.innerHTML = '<object id="' + id + '" codebase="' + codebase + '" classid="CLSID:' + classId Line 89: + '" width="0" height="0">' + Line 90: '<PARAM NAME="SecurePort" VALUE="0">' Line 91: '</object>'; // <PARAM ...> element is workaround to make spice activex addon working with ie 11 add bug reference? Line 92: container.style.width = "0px"; Line 93: container.style.height = "0px"; Line 94: container.style.position = "absolute"; Line 95: container.style.top = "0px"; -- To view, visit http://gerrit.ovirt.org/23280 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibb63ac7c0dcd269de33ced50da215e86072476cc Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Frank Kobzik <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
