Piotr Kliczewski has posted comments on this change. Change subject: tools: required changes in events data mapping. ......................................................................
Patch Set 6: (2 comments) http://gerrit.ovirt.org/#/c/23107/6/backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/utils/sender/mail/EventMailSender.java File backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/utils/sender/mail/EventMailSender.java: Line 58: Line 59: String recipient = subscriber.getMethodAddress(); Line 60: Line 61: if (StringUtils.isEmpty(recipient)) { Line 62: log.error(String.format("Email recipient is not known, please check user table ( email )" + > Well string builder is used by the compiler. I usually like to keep excepti Agree with you. Line 63: " or event_subscriber ( method_address )," + Line 64: " unable to send email for subscriber %s ," + Line 65: " message was %s:", Line 66: subscriber.getSubscriberId(), message.getMessageSubject(), message.getMessageBody())); Line 82: result.setReason(ex.getMessage()); Line 83: shouldRetry = true; Line 84: } Line 85: Line 86: for (int i = 0; i < RETRY_COUNT && shouldRetry; ++i) { > Not part of this patch. I will consider doing a patch against master. It was create for simplifying logic like this: http://gerrit.ovirt.org/#/c/22455/9/client/src/main/java/org/ovirt/vdsm/jsonrpc/client/utils/retry/Retryable.java Line 87: shouldRetry = false; Line 88: try { Line 89: // hold the next send attempt for 30 seconds in case of a busy mail server Line 90: Thread.sleep(30000); -- To view, visit http://gerrit.ovirt.org/23107 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3350d1c1caa6d730a3c7916ee0581f1aaa4a582a Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <[email protected]> Gerrit-Reviewer: Liran Zelkha <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
