Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Make LdapSearchQueryTest meaningful ......................................................................
core: Make LdapSearchQueryTest meaningful LdapSearchQueryTest did not actually perform anything, and just silently ignored a NullPointerException. This test adds some substance to it so it actually performs something. Some changes to SearchQuery itself we requried to allow proper spying of the query. Change-Id: I3133e7afd69e20b6705e24e1c56106ff75636a73 Signed-off-by: Allon Mureinik <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/itests/ldap/LdapSearchQueryTest.java 2 files changed, 101 insertions(+), 14 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, but someone else must approve Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4183 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3133e7afd69e20b6705e24e1c56106ff75636a73 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
