Alon Bar-Lev has posted comments on this change. Change subject: packaging: remove usage of /etc/ovirt-engine for configuration files ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/23311/1/ovirt-engine-reports.spec.in File ovirt-engine-reports.spec.in: Line 121 Line 122 Line 123 Line 124 Line 125 > you didn't add the new location in the report's etc folder. it is above.... or I do not follow. Line 118: rm -f /var/lib/ovirt-engine/reports.xml Line 119: fi Line 120: Line 121: %files Line 122: %dir %{_sysconfdir}/%{reports_name}/ovirt-engine-reports.conf.d > You removed the user attribute, so the ovirt user will not be able to acces it will be able to access, not to write. Line 123: %{_sysconfdir}/ovirt-engine/engine.conf.d/50-ovirt-engine-reports.conf Line 124: %{reports_java} Line 125: %{_datadir}/%{reports_name} Line 126: %if "%{name}" != "%{reports_name}" -- To view, visit http://gerrit.ovirt.org/23311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I50320bbc058e529009ae73ae22423b72fabe6d5d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yaniv Dary <[email protected]> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
