Alon Bar-Lev has uploaded a new change for review. Change subject: utils: osinfo: do not use absolute paths ......................................................................
utils: osinfo: do not use absolute paths Project should always used build time customization for all paths. This enables working at devenv mode and at different distributions and settings. Related-To: https://bugzilla.redhat.com/show_bug.cgi?id=1043206 Change-Id: I51be14104b73214602c491383fde6b34ef4f094c Signed-off-by: Alon Bar-Lev <[email protected]> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/OsRepositoryImpl.java M packaging/conf/osinfo-defaults.properties 2 files changed, 11 insertions(+), 11 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/38/23338/1 diff --git a/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/OsRepositoryImpl.java b/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/OsRepositoryImpl.java index 712564e..7e40127 100644 --- a/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/OsRepositoryImpl.java +++ b/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/OsRepositoryImpl.java @@ -353,7 +353,7 @@ @Override public String getSysprepPath(int osId, Version version) { - return getValueByVersion(idToUnameLookup.get(osId), "sysprepPath", version); + return EngineLocalConfig.getInstance().expandString(getValueByVersion(idToUnameLookup.get(osId), "sysprepPath", version)); } @Override diff --git a/packaging/conf/osinfo-defaults.properties b/packaging/conf/osinfo-defaults.properties index c48ab38..b5b5c09 100644 --- a/packaging/conf/osinfo-defaults.properties +++ b/packaging/conf/osinfo-defaults.properties @@ -131,7 +131,7 @@ os.windows_xp.id.value = 1 os.windows_xp.name.value = Windows XP os.windows_xp.derivedFrom.value = other -os.windows_xp.sysprepPath.value = /etc/ovirt-engine/sysprep/sysprep.xp +os.windows_xp.sysprepPath.value = ${ENGINE_ETC}/sysprep/sysprep.xp os.windows_xp.productKey.value = os.windows_xp.isTimezoneTypeInteger.value = true os.windows_xp.devices.network.value = rtl8139_pv, rtl8139, e1000, pv @@ -145,7 +145,7 @@ os.windows_2003.id.value = 3 os.windows_2003.name.value = Windows 2003 os.windows_2003.derivedFrom.value = windows_xp -os.windows_2003.sysprepPath.value = /etc/ovirt-engine/sysprep/sysprep.2k3 +os.windows_2003.sysprepPath.value = ${ENGINE_ETC}/sysprep/sysprep.2k3 os.windows_2003.productKey.value = os.windows_2003.isTimezoneTypeInteger.value = true os.windows_2003.devices.audio.value = ac97 @@ -156,7 +156,7 @@ os.windows_2008.id.value = 4 os.windows_2008.name.value = Windows 2008 os.windows_2008.derivedFrom.value = windows_2003 -os.windows_2008.sysprepPath.value = /etc/ovirt-engine/sysprep/sysprep.2k8 +os.windows_2008.sysprepPath.value = ${ENGINE_ETC}/sysprep/sysprep.2k8 os.windows_2008.productKey.value = # Windows2003x64(10, OsType.Windows, true), @@ -165,7 +165,7 @@ os.windows_2003x64.derivedFrom.value = windows_2003 os.windows_2003x64.bus.value = 64 os.windows_2003x64.resources.minimum.ram.value = 1024 -os.windows_2003x64.sysprepPath.value = /etc/ovirt-engine/sysprep/sysprep.2k3 +os.windows_2003x64.sysprepPath.value = ${ENGINE_ETC}/sysprep/sysprep.2k3 os.windows_2003x64.productKey.value = os.windows_2003x64.isTimezoneTypeInteger.value = true @@ -173,7 +173,7 @@ os.windows_7.id.value = 11 os.windows_7.name.value = Windows 7 os.windows_7.derivedFrom.value = windows_xp -os.windows_7.sysprepPath.value = /etc/ovirt-engine/sysprep/sysprep.w7 +os.windows_7.sysprepPath.value = ${ENGINE_ETC}/sysprep/sysprep.w7 os.windows_7.productKey.value = os.windows_7.devices.audio.value = ich6 os.windows_7.devices.diskInterfaces.value.3.3 = IDE, VirtIO_SCSI, VirtIO @@ -184,14 +184,14 @@ os.windows_7x64.bus.value = 64 os.windows_7x64.derivedFrom.value = windows_7 os.windows_7x64.resources.minimum.ram.value = 1024 -os.windows_7x64.sysprepPath.value = /etc/ovirt-engine/sysprep/sysprep.w7x64 +os.windows_7x64.sysprepPath.value = ${ENGINE_ETC}/sysprep/sysprep.w7x64 os.windows_7x64.productKey.value = # Windows2008x64(16, OsType.Windows, true), os.windows_2008x64.id.value = 16 os.windows_2008x64.name.value = Windows 2008 x64 os.windows_2008x64.derivedFrom.value = windows_2003x64 -os.windows_2008x64.sysprepPath.value = /etc/ovirt-engine/sysprep/sysprep.2k8x64 +os.windows_2008x64.sysprepPath.value = ${ENGINE_ETC}/sysprep/sysprep.2k8x64 os.windows_2008x64.productKey.value = os.windows_2008x64.devices.audio.value = ich6 @@ -206,7 +206,7 @@ os.windows_8.id.value = 20 os.windows_8.name.value = Windows 8 os.windows_8.derivedFrom.value = windows_7 -os.windows_8.sysprepPath.value = /etc/ovirt-engine/sysprep/sysprep.w8 +os.windows_8.sysprepPath.value = ${ENGINE_ETC}/sysprep/sysprep.w8 os.windows_8.productKey.value = os.windows_8.devices.display.protocols.value = vnc/cirrus @@ -215,7 +215,7 @@ os.windows_8x64.name.value = Windows 8 x64 os.windows_8x64.bus.value = 64 os.windows_8x64.derivedFrom.value = windows_7x64 -os.windows_8x64.sysprepPath.value = /etc/ovirt-engine/sysprep/sysprep.w8x64 +os.windows_8x64.sysprepPath.value = ${ENGINE_ETC}/sysprep/sysprep.w8x64 os.windows_8x64.productKey.value = os.windows_8x64.devices.display.protocols.value = vnc/cirrus @@ -223,7 +223,7 @@ os.windows_2012x64.id.value = 23 os.windows_2012x64.name.value = Windows 2012 x64 os.windows_2012x64.derivedFrom.value = windows_2008x64 -os.windows_2012x64.sysprepPath.value = /etc/ovirt-engine/sysprep/sysprep.2k12x64 +os.windows_2012x64.sysprepPath.value = ${ENGINE_ETC}/sysprep/sysprep.2k12x64 os.windows_2012x64.productKey.value = os.windows_2012x64.devices.display.protocols.value = vnc/cirrus -- To view, visit http://gerrit.ovirt.org/23338 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I51be14104b73214602c491383fde6b34ef4f094c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Alon Bar-Lev <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
