Allon Mureinik has uploaded a new change for review. Change subject: core: Fix GetWatchdogQueryTest's logic ......................................................................
core: Fix GetWatchdogQueryTest's logic The getReturnValue() method for queries always returns null, so it's pointless to check it - what's needed is to check that no watchdogs are returned for a non-existent ID. Change-Id: I349a55d5a13e06a7c2e2c0ddbd8de4e0bc46f2f1 Signed-off-by: Allon Mureinik <[email protected]> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetWatchdogQueryTest.java 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/49/23349/1 diff --git a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetWatchdogQueryTest.java b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetWatchdogQueryTest.java index 104a6e1..2c1166f 100644 --- a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetWatchdogQueryTest.java +++ b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetWatchdogQueryTest.java @@ -2,6 +2,7 @@ import java.util.Arrays; import java.util.HashMap; +import java.util.List; import org.junit.Assert; import org.junit.Ignore; @@ -30,7 +31,7 @@ Mockito.when(getDbFacadeMockInstance().getVmDeviceDao()).thenReturn(vmDeviceDAO); Mockito.when(getQueryParameters().getId()).thenReturn(new Guid("ee655a4d-effc-4aab-be2b-2f80ff40cd1c")); getQuery().executeQueryCommand(); - Assert.assertNull(getQuery().getReturnValue()); + Assert.assertTrue(((List<?>) getQuery().getQueryReturnValue().getReturnValue()).isEmpty()); } @Test -- To view, visit http://gerrit.ovirt.org/23349 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I349a55d5a13e06a7c2e2c0ddbd8de4e0bc46f2f1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
