Martin Sivák has posted comments on this change. Change subject: webadmin: added the ksm checkbox ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/23360/1/packaging/dbscripts/vds_groups_sp.sql File packaging/dbscripts/vds_groups_sp.sql: Line 31: v_enable_balloon BOOLEAN, Line 32: v_architecture INTEGER, Line 33: v_optimization_type SMALLINT, Line 34: v_spice_proxy VARCHAR(255), Line 35: v_enable_ksm BOOLEAN) I see the v_enable_ksm usage, but it is coming from a different patch.. those two should be in the same change. Line 36: RETURNS VOID Line 37: AS $procedure$ Line 38: BEGIN Line 39: INSERT INTO vds_groups(vds_group_id,description, name, free_text_comment, cpu_name, storage_pool_id, max_vds_memory_over_commit, count_threads_as_cores, compatibility_version, -- To view, visit http://gerrit.ovirt.org/23360 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I95414d676da17f00f8c23150b0cdef666a91ce74 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jiří Moskovčák <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Jiří Moskovčák <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
