Martin Sivák has posted comments on this change. Change subject: core: added ksm support ......................................................................
Patch Set 1: (3 comments) http://gerrit.ovirt.org/#/c/23358/1//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2014-01-16 15:37:37 +0100 Line 4: Commit: Jiri Moskovcak <[email protected]> Line 5: CommitDate: 2014-01-16 15:37:37 +0100 Line 6: Line 7: core: added ksm support Please change this to something like Add KSM controls, ksm has been supported for some time now. Line 8: Line 9: Since vdsm 3.3 the ksm is controlled via MoM and there should Line 10: be a way to control it from the engine. This patch ads the Line 11: initial support to the engine core. Line 6: Line 7: core: added ksm support Line 8: Line 9: Since vdsm 3.3 the ksm is controlled via MoM and there should Line 10: be a way to control it from the engine. This patch ads the Please specify the "it" from the first sentence better. Line 11: initial support to the engine core. Line 12: Line 13: Change-Id: I719d0b130fda26894db9fdaf892fd6da28bb648b Line 14: Bug-Url: https://bugzilla.redhat.com/1026980 http://gerrit.ovirt.org/#/c/23358/1/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java: Line 897: SCHEDULING_HOST_FILTERED_REASON, Line 898: SCHEDULING_ALL_HOSTS_FILTERED_OUT(ErrorType.CONFLICT), Line 899: Line 900: // memory QOS features Line 901: KSM_NOT_SUPPORTED(ErrorType.BAD_PARAMETERS), I believe this is not needed. Line 902: Line 903: // memory QOS features Line 904: QOS_BALLOON_NOT_SUPPORTED(ErrorType.BAD_PARAMETERS), Line 905: -- To view, visit http://gerrit.ovirt.org/23358 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I719d0b130fda26894db9fdaf892fd6da28bb648b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jiří Moskovčák <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Jiří Moskovčák <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
