Federico Simoncelli has posted comments on this change. Change subject: core: send domains map on connectStoragePool ......................................................................
Patch Set 2: (2 comments) http://gerrit.ovirt.org/#/c/22712/2/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java: Line 1583: MaxNumOfTriesToRunFailedAutoStartVm, Line 1584: Line 1585: @TypeConverterAttribute(Boolean.class) Line 1586: @DefaultValueAttribute("true") Line 1587: StoragePoolNoMetadata, > Consider "StoragePoolWithoutMetadata" I will use the vdsm-side name StoragePoolMemoryBackend Line 1588: Line 1589: Invalid; http://gerrit.ovirt.org/#/c/22712/2/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/ConnectStoragePoolVDSCommandParameters.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/ConnectStoragePoolVDSCommandParameters.java: Line 13: Line 14: private boolean refreshOnly; Line 15: Line 16: public ConnectStoragePoolVDSCommandParameters() { Line 17: } > Not sure this is really required - but I wouldn't mess with it right now. Agreed. Line 18: Line 19: public ConnectStoragePoolVDSCommandParameters(VDS vds, StoragePool storagePool) { Line 20: this.vds = vds; Line 21: this.storagePool = storagePool; -- To view, visit http://gerrit.ovirt.org/22712 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic16034c6757959e5d0445814a8acc2221a74f6aa Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
