Allon Mureinik has posted comments on this change. Change subject: core,webadmin: Added flag on storage pool that marks a local fs pool ......................................................................
Patch Set 6: Code-Review+1 (2 comments) Ack on the backend, please wait for a Frontend maintainer to review too. http://gerrit.ovirt.org/#/c/23072/6//COMMIT_MSG Commit Message: Line 5: CommitDate: 2014-01-16 11:03:13 +0200 Line 6: Line 7: core,webadmin: Added flag on storage pool that marks a local fs pool Line 8: Line 9: As a part of the effort to allow mixed shared domains pool, the checks on either mixed or shared, not both :-) Line 10: a storage pool to check if it's local will now be with a designated method Line 11: isLocal() which return true if the pool is local Line 12: Line 13: Relates-To: https://bugzilla.redhat.com/1038053 http://gerrit.ovirt.org/#/c/23072/6/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StoragePool.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StoragePool.java: Line 111: /** Line 112: * @return True is the Storage Pool is local, false if it's shared Line 113: */ Line 114: public boolean isLocal() { Line 115: return getStorageType() == StorageType.LOCALFS; I'd add the isLocal() method to the StorageType enum, and have this method implemented as "return getStorageType.isLocal()" Line 116: } Line 117: Line 118: public void setStorageType(StorageType value) { Line 119: storageType = value; -- To view, visit http://gerrit.ovirt.org/23072 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4f1067fd1d299a93b9555c4714b4e85ff980a830 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
