Maor Lipchuk has posted comments on this change. Change subject: engine, dao: Introduce ISCSI Bond entity, tables and dao ......................................................................
Patch Set 9: (1 comment) http://gerrit.ovirt.org/#/c/22951/9/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/IscsiBond.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/IscsiBond.java: Line 108: int result = 1; Line 109: result = prime * result + ((id == null) ? 0 : id.hashCode()); Line 110: result = prime * result + ((name == null) ? 0 : name.hashCode()); Line 111: result = prime * result + ((description == null) ? 0 : description.hashCode()); Line 112: result = prime * result + ((storagePoolId == null) ? 0 : storagePoolId.hashCode()); > what about networkIds and storageConnectionIds ? Sergey correct me if I'm wrong but I think that since those lists are transient and are not fetched from the DB you can not trust them to be in equal and hashcode Line 113: return result; Line 114: } Line 115: Line 116: @Override -- To view, visit http://gerrit.ovirt.org/22951 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I12313c02810a2f0e75016bdd78b44da43f2154d4 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
