Omer Frenkel has posted comments on this change. Change subject: core: Hot set number of CPUs using update VM ......................................................................
Patch Set 9: (3 comments) http://gerrit.ovirt.org/#/c/22757/9/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetNumberOfCpusCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetNumberOfCpusCommand.java: Line 18: * Line 19: * The execute will never throw an exception. it will rather wrap a return value in case of failure. Line 20: */ Line 21: @NonTransactiveCommandAttribute Line 22: public class SetNumberOfCpusCommand<T extends VmManagementParametersBase> extends VmManagementCommandBase<T> { maybe should be called "HotSetNumberOfCpusCommand" Line 23: Line 24: public SetNumberOfCpusCommand(T parameters) { Line 25: super(parameters); Line 26: } Line 30: if (getVm() == null) { Line 31: failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_VM_NOT_EXIST); Line 32: } Line 33: if (getVm().getStatus() != VMStatus.Up) { Line 34: failCanDoAction(VdcBllMessages.VAR__VM_STATUS__UP); this message will produce the string "Up", please use something else Line 35: } Line 36: if (getParameters().getVm().getNumOfCpus() > SlaValidator.getEffectiveCpuCores(getVds())) { Line 37: failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_VDS_VM_CPUS); Line 38: } http://gerrit.ovirt.org/#/c/22757/9/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java: Line 106: int newSockets = getParameters().getVm().getNumOfSockets(); Line 107: Line 108: if (getVm().getStatus() == VMStatus.Up && currentSockets != newSockets) { Line 109: setNumberOfCpusResult = getBackend().runInternalAction( Line 110: VdcActionType.SetNumberOfCpus, new VmManagementParametersBase(newVmStatic)); worth audit logging the can do action message in case of failure Line 111: getVm().setNumOfSockets(setNumberOfCpusResult.getSucceeded() ? newSockets : currentSockets); Line 112: } Line 113: } Line 114: -- To view, visit http://gerrit.ovirt.org/22757 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I464a3dda5f143d1fcef63fd903eb615b01efe081 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <[email protected]> Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <[email protected]> Gerrit-Reviewer: Leonardo Bianconi <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Vitor de Lima <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
