Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: do not modify jasperserver files ......................................................................
Patch Set 3: (2 comments) http://gerrit.ovirt.org/#/c/23317/3/packaging/legacy-setup/ovirt-engine-reports-setup.py File packaging/legacy-setup/ovirt-engine-reports-setup.py: Line 208 Line 209 Line 210 Line 211 Line 212 > e want to use the secure JDBC driver, that is why we copy it to the buildom we use for install whatever jasper is provided with, once installed we replace it with our own. we do not want to modify jasper, so alternative is to copy the complete directory. but as we use jasper binary artifacts anyway I see no advantage of doing so. Line 241 Line 242 Line 243 Line 244 Line 245 > this change will cause a bug. postgresql-jdbc.jar will be loaded as the def no, this will not load anything as there is no such file. -- To view, visit http://gerrit.ovirt.org/23317 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7eaa6f20d444b82161571d2abc2d7b9f78faa626 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yaniv Dary <[email protected]> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
