Mike Kolesnik has posted comments on this change.
Change subject: core : overloading engine with tasks will cause bin to get
stuck with exception: Failed to acquire a permit within 5 MINUTES (#813817)
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/itests/AbstractBackendTest.java
Line 67: // replace this resource manager with a test resource
manager
Please delete these comments too
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java
Line 61: public void init() {
Please add private ctor as this is singleton design pattern.
--
To view, visit http://gerrit.ovirt.org/4252
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia641e5348b9bda51dffadab2aae93719f58e975b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
