Ori Liel has posted comments on this change. Change subject: restapi: Introduced statistics for glustervolumes ......................................................................
Patch Set 8: (2 comments) http://gerrit.ovirt.org/#/c/22579/8/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/VolumeStatisticalQuery.java File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/VolumeStatisticalQuery.java: Line 36: } Line 37: Line 38: @Override Line 39: public Statistic adopt(Statistic statistic) { Line 40: statistic.setGlusterVolume(clone(parent)); why is this clone necessary? Line 41: return statistic; Line 42: } Line 43: Line 44: private GlusterVolume clone(GlusterVolume volume) { Line 40: statistic.setGlusterVolume(clone(parent)); Line 41: return statistic; Line 42: } Line 43: Line 44: private GlusterVolume clone(GlusterVolume volume) { Same question. Compare to other Statistical Queries. For example - VmStatisticalQuery - no clone(vm) there. I don't think you need this. Line 45: GlusterVolume cloned = new GlusterVolume(); Line 46: cloned.setId(volume.getId()); Line 47: cloned.setBricks(volume.getBricks()); Line 48: cloned.setCluster(volume.getCluster()); -- To view, visit http://gerrit.ovirt.org/22579 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6b17170f403c6ac320829b23b8e2d03b537b8ff2 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Ori Liel <[email protected]> Gerrit-Reviewer: Ramesh N <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
