Liron Ar has posted comments on this change. Change subject: vdsbroker: improve the domain visibility cache ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/23370/3/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java: Line 1056: vds.getId(), poolDomain.getId(), domainStatus.toString()); Line 1057: } Line 1058: Line 1059: domainsVisibility.setVdsDomainStatus(vds.getId(), poolDomain.getId(), domainStatus); Line 1060: > why do we keep also the domains that are fine? ignore Line 1061: if (domainStatus == DomainVisibility.Status.UNREPORTED Line 1062: || domainStatus == DomainVisibility.Status.UNREACHABLE) { Line 1063: setTimerIfAbsent(poolDomain.getId()); Line 1064: } else if (domainsVisibility.getDomainProblematicVdsList(poolDomain.getId()).size() == 0) { -- To view, visit http://gerrit.ovirt.org/23370 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id74f12d108f75924fbff28409a89bc1caff05908 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
