Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: export users in any type of upgrade ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/23427/1/packaging/legacy-setup/ovirt-engine-reports-setup.py File packaging/legacy-setup/ovirt-engine-reports-setup.py: Line 1126: savedDir = None Line 1127: if preserveReports: Line 1128: exportScheduale() Line 1129: Line 1130: if hasData or preserveReports: > why is this needed. hasData should be true in any case that db contains dat you tell me... this is working now... in this complex flags which I do not understand. anyway the import bellow is if preserveReports... and then once again if hasData. all this is going away in favour of simple update/redeploy modes, a failure grade to whoever wrote this logic. Line 1131: savedDir = utils.exportUsers() Line 1132: Line 1133: if not isWarInstalled() and not hasData and adminPass is None: Line 1134: adminPass = getAdminPass() -- To view, visit http://gerrit.ovirt.org/23427 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0e09f790925e0aa540b3ada0642d8b1515effd3b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Yaniv Dary <[email protected]> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
