Michael Kublin has posted comments on this change. Change subject: core: Adding disk changes boot_order ......................................................................
Patch Set 1: I would prefer that you didn't submit this (3 inline comments) Seting -1, because u got +2 .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java Line 119: // set vm images but we can use getVm().getDisks() .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java Line 238: // set vm images we don't need to update bootOrder for lun disks ? .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmDeviceCommonUtils.java Line 198: same here, what about boot order of direct lun disks -- To view, visit http://gerrit.ovirt.org/4104 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id14939c279f6d84a973766d7fc202512c378d114 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <[email protected]> Gerrit-Reviewer: Michael Kublin <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
