Allon Mureinik has posted comments on this change. Change subject: engine: Introduce commands to manage iscsi bonds entities ......................................................................
Patch Set 12: Code-Review+2 (1 comment) Please remember to remove the @LockNameAttribute from AddIscsiBondCommand when you rebase. http://gerrit.ovirt.org/#/c/22952/12/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddIscsiBondCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddIscsiBondCommand.java: Line 13: import org.ovirt.engine.core.compat.Guid; Line 14: import org.ovirt.engine.core.utils.transaction.TransactionMethod; Line 15: import org.ovirt.engine.core.utils.transaction.TransactionSupport; Line 16: Line 17: @LockIdNameAttribute Should be removed if there are no locks. Line 18: @NonTransactiveCommandAttribute Line 19: public class AddIscsiBondCommand<T extends AddIscsiBondParameters> extends BaseIscsiBondCommand<T> { Line 20: Line 21: public AddIscsiBondCommand(T parameters) { -- To view, visit http://gerrit.ovirt.org/22952 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06890ea40d22b86d9421cb1b0c68ea28bc430b0a Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Amador Pahim <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
