Yair Zaslavsky has posted comments on this change. Change subject: tools: remove auxiliary email address from EventSender interface ......................................................................
Patch Set 9: Code-Review+1 (1 comment) please look again at the SQL uppercase changes... http://gerrit.ovirt.org/#/c/23106/9/backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/NotificationService.java File backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/NotificationService.java: Line 110: int updatedRecords; Line 111: try { Line 112: connection = ds.getConnection(); Line 113: statement = connection.prepareStatement( Line 114: "UPDATE audit_log SET " + once again , SQL syntax got changed. It's not that major comment, but still unrelated to patch. Line 115: "processed = 'true' " + Line 116: "WHERE " + Line 117: "processed = 'false' " + Line 118: "AND log_time < ?" -- To view, visit http://gerrit.ovirt.org/23106 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic69ff7541fca8347fb7cb85665934ca704fa9d06 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
