[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: webadmin, userportal: Fix UiCommon Editor typos

[rgolan]

Hello Vojtech Szocs,

I'd like you to do a code review.  Please visit

    http://gerrit.ovirt.org/23476

to review the following change.

Change subject: webadmin,userportal: Fix UiCommon Editor typos
......................................................................

webadmin,userportal: Fix UiCommon Editor typos

Fixed some typos/formatting in Editor driver classes.

Change-Id: I38c79a3c617c9a8c8f7dcd204af9a9bc6039192b
Signed-off-by: Vojtech Szocs <vsz...@redhat.com>
---
M 
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/binding/UiCommonEditorDriverGenerator.java
M 
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/editor/AbstractUiCommonModelEditorDriver.java
2 files changed, 7 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/76/23476/1

diff --git 
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/binding/UiCommonEditorDriverGenerator.java
 
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/binding/UiCommonEditorDriverGenerator.java
index 93990b6..9148f53 100644
--- 
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/binding/UiCommonEditorDriverGenerator.java
+++ 
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/binding/UiCommonEditorDriverGenerator.java
@@ -17,8 +17,7 @@
 import com.google.gwt.editor.rebind.model.EditorModel;
 import com.google.gwt.user.rebind.SourceWriter;
 
-public class UiCommonEditorDriverGenerator extends
-        AbstractEditorDriverGenerator {
+public class UiCommonEditorDriverGenerator extends 
AbstractEditorDriverGenerator {
 
     private JClassType entityModelType;
     private JClassType listModelType;
@@ -64,7 +63,7 @@
         this.model = model;
         this.sw = sw;
 
-        logger.log(Type.DEBUG, "Strating to write additional Driver code"); 
//$NON-NLS-1$
+        logger.log(Type.DEBUG, "Starting to write additional Driver code"); 
//$NON-NLS-1$
         writeListenerMap();
         writeEventMap();
         writeOwnerModels();
@@ -75,7 +74,7 @@
      * Writes the UiCommonListenerMap for the edited model
      */
     private void writeListenerMap() {
-        logger.log(Type.DEBUG, "Strating to write ListenerMap"); //$NON-NLS-1$
+        logger.log(Type.DEBUG, "Starting to write ListenerMap"); //$NON-NLS-1$
         sw.println();
         sw.println("@Override"); //$NON-NLS-1$
         sw.println("protected " + UiCommonListenerMap.class.getName() + " 
getListenerMap() {"); //$NON-NLS-1$ //$NON-NLS-2$
@@ -127,7 +126,7 @@
      * Writes the UiCommonEventMap for the edited model
      */
     private void writeEventMap() {
-        logger.log(Type.DEBUG, "Strating to write EventMap"); //$NON-NLS-1$
+        logger.log(Type.DEBUG, "Starting to write EventMap"); //$NON-NLS-1$
 
         sw.println();
         sw.println("@Override"); //$NON-NLS-1$
@@ -177,7 +176,7 @@
      * Writes the map of the owner Models
      */
     private void writeOwnerModels() {
-        logger.log(Type.DEBUG, "Strating to write OwnerModels"); //$NON-NLS-1$
+        logger.log(Type.DEBUG, "Starting to write OwnerModels"); //$NON-NLS-1$
         sw.println();
         sw.println("@Override"); //$NON-NLS-1$
         sw.println("protected java.util.Map<String, 
org.ovirt.engine.ui.uicommonweb.models.EntityModel> getOwnerModels() {"); 
//$NON-NLS-1$
diff --git 
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/editor/AbstractUiCommonModelEditorDriver.java
 
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/editor/AbstractUiCommonModelEditorDriver.java
index 3abdbdf..a215f3b1 100644
--- 
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/editor/AbstractUiCommonModelEditorDriver.java
+++ 
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/editor/AbstractUiCommonModelEditorDriver.java
@@ -25,8 +25,8 @@
 public abstract class AbstractUiCommonModelEditorDriver<T extends Model, E 
extends Editor<T>>
         extends BaseEditorDriver<T, E> implements SimpleBeanEditorDriver<T, E> 
{
 
-    private IEventListener propertyChangeListener = null;
-    private EditorVisitor visitor = null;
+    private IEventListener propertyChangeListener;
+    private EditorVisitor visitor;
 
     /**
      * {@inheritDoc} <BR>
@@ -97,7 +97,6 @@
     /**
      * Returns a Map of the parent ListModel for all the ListModelBoxes being 
edited.
      *
-     * @param absolutePath
      * @return
      */
     protected abstract Map<String, EntityModel> getOwnerModels();


-- 
To view, visit http://gerrit.ovirt.org/23476
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I38c79a3c617c9a8c8f7dcd204af9a9bc6039192b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches