Tomas Jelinek has posted comments on this change.
Change subject: frontend: Builders on frontend
......................................................................
Patch Set 3:
nice!!!
One comment: you could use the CompositeBuilder to unify the parts common for
more places. For VmListModel and UserPortalListModel it would be:
class CommonVmListUserPortalListCompositeBuilder extends
CompositeBuilder<UnitVmModel, VmBase> {
public CommonVmListUserPortalListCompositeBuilder() {
super(
new NameUnitToVmBaseBuilder(),
new CommonUnitToVmBaseBuilder(),
new KernelParamsUnitToVmBaseBuilder(),
new QuotaUnitToVmBaseBuilder(),
new MigrationOptionsUnitToVmBaseBuilder(),
new DedicatedVmForVdsUnitToVmBaseBuilder(),
new SingleQxlUnitToVmBaseBuilder(),
new UsbPolicyUnitToVmBaseBuilder(),
new PriorityUnitToVmBaseBuilder(),
new AllowConsoleReconnectUnitToVmBaseBuilder(),
new AutoStartupUnitToVmBaseBuilder(),
new DescriptionUnitToVmBaseBuilder(),
new RunAndPauseUnitToVmBaseBuilder(),
new StatelessUnitToVmBaseBuilder()
);
}
}
and this can than be used as a normal builder like this in the VmListModel:
BuilderExecutor.build(model, getcurrentVm().getStaticData(),
new CommonVmListUserPortalListCompositeBuilder(),
new CommentUnitToVmBaseBuilder());
--
To view, visit http://gerrit.ovirt.org/23474
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7cbd0f8c79ae13dd368a7542262397168c363f57
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
