Martin Peřina has posted comments on this change. Change subject: tools: Notification properties changes. ......................................................................
Patch Set 8: (1 comment) http://gerrit.ovirt.org/#/c/23080/8/backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/utils/NotificationProperties.java File backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/utils/NotificationProperties.java: Line 216: String emailUser = getProperty(NotificationProperties.MAIL_USER, true); Line 217: if (StringUtils.isEmpty(emailUser) Line 218: && (MAIL_SMTP_ENCRYPTION_SSL.equals(getProperty(MAIL_SMTP_ENCRYPTION, true)) Line 219: || MAIL_SMTP_ENCRYPTION_TLS.equals(getProperty(MAIL_SMTP_ENCRYPTION, true)) Line 220: || StringUtils.isNotEmpty(getProperty(NotificationProperties.MAIL_PASSWORD, true)))) { Still the same, please undo formatting changes here Line 221: throw new IllegalArgumentException( Line 222: String.format( Line 223: "'%s' must be set when SSL or TLS is enabled or when password is set", Line 224: NotificationProperties.MAIL_USER)); -- To view, visit http://gerrit.ovirt.org/23080 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5753ba2cad2de90a7f2d14bd4675edc1dd35045e Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
