Maor Lipchuk has posted comments on this change. Change subject: core: Remove storage type parameter in create storage pool VDS command ......................................................................
Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/23293/5/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CreateStoragePoolVDSCommand.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CreateStoragePoolVDSCommand.java: Line 19: for (int i = 0; i < guids.length; i++) { Line 20: ids[i] = guids[i].toString(); Line 21: } Line 22: Line 23: //The first parameter, poolType parameter is ignored by VDSM and thus can be set to any arbitrary value Please use the formatter here (you should have extra space "// The" instead "//The" Line 24: status = getBroker().createStoragePool(0, Line 25: getParameters().getStoragePoolId().toString(), getParameters().getStoragePoolName(), Line 26: getParameters().getMasterDomainId().toString(), ids, getParameters().getMasterVersion(), Line 27: Config.<String> getValue(ConfigValues.LockPolicy), -- To view, visit http://gerrit.ovirt.org/23293 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia7efe3008fcdcbde4336ad026249b290b6b3eed5 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
