Liron Ar has posted comments on this change. Change subject: core: HttpConnManager - add connection/sockets timeouts ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/23533/1/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/xmlrpc/XmlRpcUtils.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/xmlrpc/XmlRpcUtils.java: Line 142: } Line 143: Line 144: private static HttpClient createHttpClient(int clientRetries) { Line 145: HttpConnectionManagerParams params = new HttpConnectionManagerParams(); Line 146: params.setConnectionTimeout(CONN_TIMEOUT); > If I understand correctly both the connection timeout and socket timeout ar The socket timeout isn't used, we use a xml-rpc connection timeout (which i'll replace with this constant) and we don't use currently a socket timeout but a timeout for the whole operation. Line 147: params.setSoTimeout(SOCK_TIMEOUT); Line 148: MultiThreadedHttpConnectionManager httpConnectionManager = new MultiThreadedHttpConnectionManager(); Line 149: httpConnectionManager.setParams(params); Line 150: // Create the client: -- To view, visit http://gerrit.ovirt.org/23533 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4e927ce28c8fdd9bcdcdb37e23b8d45c7515fd55 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
