Oved Ourfali has posted comments on this change. Change subject: authentication: pki: cleanup properties ......................................................................
Patch Set 1: Code-Review+1 (1 comment) minor comment/question. http://gerrit.ovirt.org/#/c/23535/1/ovirt-engine-reports/EngineAuthentication/src/main/java/org/ovirt/authentication/EngineSimplePreAuthFilter.java File ovirt-engine-reports/EngineAuthentication/src/main/java/org/ovirt/authentication/EngineSimplePreAuthFilter.java: Line 322: this.sslInsecure = sslInsecure; Line 323: } Line 324: Line 325: public void setSslNoHostVerification(boolean sslNoHostVerification) { Line 326: this.sslNoHostVerification = sslNoHostVerification; aren't the getters required by spring security? If not, I'm okay with removing them. Makes sense that they aren't required indeed, but not sure about that. Line 327: } -- To view, visit http://gerrit.ovirt.org/23535 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5ebc86f05b508a069e81639356d10477ee0a3acf Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Yaniv Dary <[email protected]> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
