Alon Bar-Lev has posted comments on this change. Change subject: authentication: pki: cleanup ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/23534/1/ovirt-engine-reports/EngineAuthentication/src/main/java/org/ovirt/authentication/EngineSimplePreAuthFilter.java File ovirt-engine-reports/EngineAuthentication/src/main/java/org/ovirt/authentication/EngineSimplePreAuthFilter.java: Line 145: @Override Line 146: public X509Certificate[] getAcceptedIssuers() { Line 147: return new X509Certificate[] {}; Line 148: } Line 149: } > Why is doing it here better then doing that in an external method? it is one flow, no need to jump back and forth. even if I split it I use function that return TrustManagers[] and no handle the sslcontext in two functions. Line 150: }; Line 151: } Line 152: else { Line 153: if (trustStorePassword == null || trustStorePath == null) { -- To view, visit http://gerrit.ovirt.org/23534 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie12f9bb3156ef280147a19c55bab019517b33ee9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Yaniv Dary <[email protected]> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
