Juan Hernandez has posted comments on this change. Change subject: restapi: Vm Init - new Feature ......................................................................
Patch Set 22: (2 comments) http://gerrit.ovirt.org/#/c/23021/22/backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd File backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd: Line 177: <xs:element ref="template" minOccurs="0" maxOccurs="1"/> Line 178: <!-- For Setup Networks --> Line 179: <xs:element ref="host_nics" minOccurs="0" maxOccurs="1"/> Line 180: <xs:element name="guest_nic_configuration" type="GuestNicConfiguration"/> Line 181: <xs:element name="guest_nics_configuation" type="GuestNicsConfiguration"/> These two should be top level declarations, not inside ActionParameterGroup. Line 182: <xs:element name="check_connectivity" type="xs:boolean" minOccurs="0"/> Line 183: <xs:element name="connectivity_timeout" type="xs:int" minOccurs="0"/> Line 184: <!-- A VM can be started paused --> Line 185: <xs:element name="pause" type="xs:boolean" minOccurs="0" maxOccurs="1"/> Line 3120: </xs:element> Line 3121: </xs:sequence> Line 3122: </xs:extension> Line 3123: </xs:complexContent> Line 3124: </xs:complexType> Here is where you should place the lop level declarations of the above elements. Line 3125: Line 3126: <xs:complexType name="GuestNicConfiguration"> Line 3127: <xs:sequence> Line 3128: <xs:element name="name" type="xs:string" minOccurs="0" maxOccurs="1"/> -- To view, visit http://gerrit.ovirt.org/23021 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I817de4fd7c7efcc3740583ede7a96bd522015660 Gerrit-PatchSet: 22 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Ori Liel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
