Oved Ourfali has posted comments on this change. Change subject: core: fix pass bridged and mtu property in add/edit network api ......................................................................
Patch Set 3: Looks good to me, but someone else must approve (2 inline comments) minor comments. also s/incase/in case/ in the commit message. .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachNetworkToVdsInterfaceCommand.java Line 60: logicalNetwork, just make sure it looks better in the file with regards to indentation, as it looks horrible here :-) Line 138: consider putting the network name in a parameter. -- To view, visit http://gerrit.ovirt.org/4198 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifacdace1f1517df13d087ed6102cd30496c45855 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
