Allon Mureinik has uploaded a new change for review.

Change subject: core: Fix broken DAO tests broken
......................................................................

core: Fix broken DAO tests broken

Patch b5dbfd09c72e8f06e72a9c951ec9ad75d6ffa548 (Vm Init - new Feature)
removed the domain column from vm_static, but neglected to remove it
from all the row descriptions in fixtures.xml.

The result were a few bogus row definitions where the old description
value was interpreted as the creation_date (which is the next column)
value. Since these strings could no be cast to dates, the fixtures data
could not be written to the database, causing almost all the DAO tests
to fail.

Change-Id: If107a7c8ab009d82317239bb1c55fca82ecfadfa
Signed-off-by: Allon Mureinik <[email protected]>
---
M backend/manager/modules/dal/src/test/resources/fixtures.xml
1 file changed, 0 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/04/23704/1

diff --git a/backend/manager/modules/dal/src/test/resources/fixtures.xml 
b/backend/manager/modules/dal/src/test/resources/fixtures.xml
index 581f556..cc9114d 100644
--- a/backend/manager/modules/dal/src/test/resources/fixtures.xml
+++ b/backend/manager/modules/dal/src/test/resources/fixtures.xml
@@ -1909,7 +1909,6 @@
             <value>1</value>
             <null />
             <value>b399944a-81ab-4ec5-8266-e19ba7c3c9d1</value>
-            <value></value>
             <value>2010-11-21 16:39:27</value>
             <value>0</value>
             <value>1</value>
@@ -2336,7 +2335,6 @@
             <value>0</value>
             <null />
             <value>b399944a-81ab-4ec5-8266-e19ba7c3c9d1</value>
-            <value></value>
             <value>2010-11-18 11:13:24</value>
             <null />
             <value>1</value>
@@ -2390,7 +2388,6 @@
             <value>0</value>
             <null />
             <value>b399944a-81ab-4ec5-8266-e19ba7c3c9d1</value>
-            <value></value>
             <value>2010-11-18 11:13:24</value>
             <null />
             <value>1</value>


-- 
To view, visit http://gerrit.ovirt.org/23704
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If107a7c8ab009d82317239bb1c55fca82ecfadfa
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to