Roy Golan has posted comments on this change.
Change subject: tools: Add action reload to engine-config
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(5 inline comments)
....................................................
File
backend/manager/tools/engine-config/src/main/java/org/ovirt/engine/core/config/EngineConfigLogic.java
Line 152: return br.readLine();
use java console facility:
System.console().readLine()
FYI - about the former approach, always care to close your resource:
try {
input.close();
br.close();
} catch (Exception e) {
// Ignore
}
return br.readLine();
Line 165: log.debug("starting user dialog.");
consider doing this in a loop, till the user have entered an input which isn't
null?
Line 168: return br.readLine();
use System.console().readLine()
Line 176: log.debug("starting password dialog.");
again a loop?
Line 179: return br.readLine();
reading the password bare from CLI is considered a risk.
use:
new String(System.console().readPassword());
--
To view, visit http://gerrit.ovirt.org/4124
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I22e407ad9a1982b7bc3e50cac35a9c5a34da5581
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Muli Salem <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
