Michael Pasternak has posted comments on this change. Change subject: cli: Change version number to 3.5.0.0 ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/23669/1/Makefile File Makefile: Line 1: all: rpm Line 2: Line 3: rpmrelease:=0.1 why is this offset needed? Line 4: rpmversion=3.5.0.0 Line 5: RPMTOP=$(shell bash -c "pwd -P")/rpmtop Line 6: SPEC=ovirt-engine-cli.spec Line 7: http://gerrit.ovirt.org/#/c/23669/1/setup.py File setup.py: Line 7: Line 8: Line 9: version_info = { Line 10: 'name': 'ovirt-shell', Line 11: 'version': '3.5.0.0', why do you omit -1? this is a version schema everybody familiar with Line 12: 'description': 'A command-line interface to oVirt Virtualization', Line 13: 'author': 'Michael Pasternak', Line 14: 'author_email': '[email protected]', Line 15: 'url': 'http://www.ovirt.org/wiki/CLI', -- To view, visit http://gerrit.ovirt.org/23669 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If03fdfd2cede2ed52b6f3a95f275cb8b95a2a312 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <[email protected]> Gerrit-Reviewer: Michael Pasternak <[email protected]> Gerrit-Reviewer: Ori Liel <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
