Roy Golan has posted comments on this change. Change subject: Implementation for CPU topology reporting ......................................................................
Patch Set 6: why won't you rely on lscpu parsable output instead of manually parsing this? lscpu is part of util-linux, which is a kernel tool. its not going to disappear or something. the tool should also be updated with the latest changes on /sys, if any so this manual parsing may be outdated while lscpu won't also, this is very hard work for something which is already done -- To view, visit http://gerrit.ovirt.org/23268 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If937fd33d2efa11425c814188df2087a85af8357 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
