Sandro Bonazzola has uploaded a new change for review. Change subject: HyperVisorData: Run ssh with -n ......................................................................
HyperVisorData: Run ssh with -n The fix to https://bugzilla.redhat.com/1010472 was to add '-t' to provide a controlling tty to the remote ausearch. This caused the tty to be garbled under certain conditions. A comment in that bug mentions that this is due to ausearch expecting a log file path on stdin if stdin is a pipe. So this change makes ssh run with '-n' thus not providing an stdin to the remote command. Change-Id: Id3e65b5564eb34e72e57f824fb86f9c50acfa1c5 Bug-Url: https://bugzilla.redhat.com/1041749 Signed-off-by: Sandro Bonazzola <[email protected]> Signed-off-by: Yedidyah Bar David <[email protected]> (cherry picked from commit 6de9a18ddcf88d21acc1687fd7bc7e3ac50017b7) --- M src/__main__.py 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-log-collector refs/changes/96/23796/1 diff --git a/src/__main__.py b/src/__main__.py index 0b20647..6fef027 100755 --- a/src/__main__.py +++ b/src/__main__.py @@ -569,9 +569,9 @@ def format_ssh_command(self, cmd="ssh"): cmd = "/usr/bin/%s " % cmd - # add a controlling tty + # disable reading from stdin if cmd.startswith("/usr/bin/ssh"): - cmd += "-t " + cmd += "-n " if "ssh_port" in self.configuration: port_flag = "-p" if cmd.startswith("/usr/bin/ssh") else "-P" -- To view, visit http://gerrit.ovirt.org/23796 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id3e65b5564eb34e72e57f824fb86f9c50acfa1c5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: ovirt-log-collector-3.4 Gerrit-Owner: Sandro Bonazzola <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
