Shireesh Anjal has posted comments on this change.
Change subject: restapi: RSDL metadata for gluster related REST api
......................................................................
Patch Set 5: (12 inline comments)
Responses inline. New patch-set to follow.
....................................................
File
backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata_v-3.1.yaml
Line 1982: search: {context: query, type: 'xs:string', value: query,
required: false}
We do intend to implement search for volumes in Backend. In fact it already
exists, and will be enhanced if necessary to work with the REST api.
Line 1983: case_sensitive: {context: matrix, type: 'xs:boolean', value:
true|false, required: false}
Same response as above.
Line 1993: gluster_volume.gluster_bricks--COLLECTION:
{gluster_brick.server_id: 'xs:string', gluster_brick.brick_dir: 'xs:string'}
A gluster volume cannot exist without a brick, and hence this is required. I
will rename gluster_brick to just brick as discussed.
Line 1997: gluster_volume.stripe_count: 'xs:int'
Yes, they are unsignedShort! Will update here as well.
Line 2000: gluster_volume.gluster_options--COLLECTION:
{gluster_option.key: 'xs:string', gluster_option.value: 'xs:string'}
As per the latest review comments, options will be treated as inline collection
in the volume options. So I'll retain this, replacing gluster_option with just
option.
Line 2009: optionalArguments: {action.force: 'xs:boolean'}
The gluster CLI supports a "--force" argument for the "volume start" command.
It is used when you want to start any dead brick services of the volume.
Line 2024: parameterType: GlusterBricks
As explained in another patch, there are situations where multiple bricks have
to be added to a gluster volume in one go, and hence we have to accept a
collection of bricks here.
Line 2027: gluster_bricks--COLLECTION: {gluster_brick.server_id:
'xs:string', gluster_brick.brick_dir: 'xs:string'}
same response as above.
Line 2034: parameterType: GlusterOptions
This api is removed now, as options are not business entities
Line 2037: gluster_options--COLLECTION: {gluster_option.key:
'xs:string', gluster_option.value: 'xs:string'}
This api is removed now, as options are not business entities
Line 2041: - name:
/api/clusters/{cluster:id}/glustervolumes/{glustervolume:id}/bricks/{brick:id}/replace|rel=replace
Yes, your assumption is right!
Line 2041: - name:
/api/clusters/{cluster:id}/glustervolumes/{glustervolume:id}/bricks/{brick:id}/replace|rel=replace
It invokes the "gluster volume replace-brick existing-brick new-brick" command
on the gluster server, which replaces the existing-brick with the new-brick,
moving all the data from existing-brick to new-brick in the process.
--
To view, visit http://gerrit.ovirt.org/3918
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2883e452b8f6bc4b51bd2199fbd712f56dd96ab5
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shireesh Anjal <san...@redhat.com>
Gerrit-Reviewer: Eoghan Glynn <eoghan.gl...@gmail.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Ori Liel <ol...@redhat.com>
Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
