Tomas Jelinek has posted comments on this change. Change subject: webadmin: disable virtio-scsi for unsupported OSes ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/23861/1/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java: Line 1164: else { Line 1165: if (Guid.isNullOrEmpty(vmId)) { Line 1166: VDSGroup cluster = getModel().getSelectedCluster(); Line 1167: boolean isVirtioScsiEnabled = (Boolean) AsyncDataProvider.getConfigValuePreConverted( Line 1168: ConfigurationValues.VirtIoScsiEnabled, cluster.getcompatibility_version().getValue()); There is a chance that cluster will be null at this point which would cause NPE. Line 1169: getModel().getIsVirtioScsiEnabled().setEntity(isVirtioScsiEnabled); Line 1170: } Line 1171: else { Line 1172: AsyncDataProvider.isVirtioScsiEnabledForVm(new AsyncQuery(getModel(), new INewAsyncCallback() { -- To view, visit http://gerrit.ovirt.org/23861 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0256b84e1c82a6c2330287f1e68385d785d26b26 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Daniel Erez <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
