Sergey Gotliv has posted comments on this change. Change subject: engine: Only iSCSI storage connections are viable for iSCSI Bond ......................................................................
Patch Set 1: (5 comments) http://gerrit.ovirt.org/#/c/23720/1//COMMIT_MSG Commit Message: Line 4: Commit: Sergey Gotliv <[email protected]> Line 5: CommitDate: 2014-01-26 16:18:53 +0200 Line 6: Line 7: engine: Only iSCSI storage connections are viable for iSCSI Bond Line 8: > Please add more detail Please, suggest what additional information I can provide here. Line 9: Change-Id: Iae30db6aa0c5d2989e9e31566d6555d70259799e http://gerrit.ovirt.org/#/c/23720/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetStorageConnectionsByDataCenterIdAndStorageTypeQuery.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetStorageConnectionsByDataCenterIdAndStorageTypeQuery.java: Line 20: Line 21: List<StorageServerConnections> connections = getDbFacade().getStorageServerConnectionDao() Line 22: .getAllConnectableStorageSeverConnection(getParameters().getId()); Line 23: Line 24: for (StorageServerConnections connection : connections) { > Now that datacenter type is removed, we should probably introduce some help Done Line 25: if (connection.getstorage_type() == getParameters().getStorageType()) { Line 26: result.add(connection); Line 27: } Line 28: } http://gerrit.ovirt.org/#/c/23720/1/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetStorageConnectionsByDataCenterIdAndStorageTypeQueryParameters.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetStorageConnectionsByDataCenterIdAndStorageTypeQueryParameters.java: Line 2: Line 3: import org.ovirt.engine.core.common.businessentities.StorageType; Line 4: import org.ovirt.engine.core.compat.Guid; Line 5: Line 6: public class GetStorageConnectionsByDataCenterIdAndStorageTypeQueryParameters extends IdQueryParameters { > suggestion: I must say, it looks like the longest class name I saw in oVirt Done Line 7: Line 8: private static final long serialVersionUID = 3630182261969029480L; Line 9: Line 10: private StorageType storageType; http://gerrit.ovirt.org/#/c/23720/1/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java: Line 2509: IdQueryParameters params = new IdQueryParameters(storagePoolId); Line 2510: Frontend.getInstance().runQuery(VdcQueryType.GetNetworksByDataCenterId, params, aQuery); Line 2511: } Line 2512: Line 2513: public static void getDataCenterStorageConnectionsByType(final AsyncQuery aQuery, > s/getDataCenterStorageConnectionsByType/getStorageConnectionsByDataCenterId Done Line 2514: final Guid storagePoolId, Line 2515: final StorageType storageType) { Line 2516: aQuery.converterCallback = new IAsyncConverter() { Line 2517: @Override Line 2510: Frontend.getInstance().runQuery(VdcQueryType.GetNetworksByDataCenterId, params, aQuery); Line 2511: } Line 2512: Line 2513: public static void getDataCenterStorageConnectionsByType(final AsyncQuery aQuery, Line 2514: final Guid storagePoolId, > why final? Done Line 2515: final StorageType storageType) { Line 2516: aQuery.converterCallback = new IAsyncConverter() { Line 2517: @Override Line 2518: public Object Convert(Object source, AsyncQuery _asyncQuery) -- To view, visit http://gerrit.ovirt.org/23720 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iae30db6aa0c5d2989e9e31566d6555d70259799e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
