Martin Peřina has posted comments on this change.

Change subject: core: Adds cli parser supporting short and long args
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.ovirt.org/#/c/23841/3/backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/cli/ExtendedCliParserTest.java
File 
backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/cli/ExtendedCliParserTest.java:

Line 191:         String argName2 = "-f";
Line 192:         String argName3 = "--output";
Line 193:         String argValue3 = "/dev/null";
Line 194:         String argName4 = "-u";
Line 195:         String argValue4 = "root";
> oh... just noticed --output=/dev/null should also be accepted.
It's accepted and works fine (lines 214-215)
Line 196: 
Line 197:         final String[] args = {
Line 198:                 argName1,
Line 199:                 argName2,


-- 
To view, visit http://gerrit.ovirt.org/23841
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id7fe3bf761bd26c86d684ad1dc85751d4492239b
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Martin Peřina <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to