Michael Pasternak has posted comments on this change. Change subject: restapi: non admin user api - Filtering user queries (#783087) ......................................................................
Patch Set 1: I would prefer that you didn't submit this (3 inline comments) following three comments describes changes i would like to be done on all files, e.g i would like setFiltered() be implemented in generic getX() methods rather than on each call in priory, and in places where passed parameters class directly to be used some (new) utility, like Foo.setFiltered(new X()) this way we will abstract this functionality in generic way. thanks .................................................... File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendStorageDomainContentResource.java Line 88: params.setFiltered(SessionUtils.isFiltered()); why this is not in getEntity()? it would solve this in generic way... .................................................... File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendAssignedRolesResource.java Line 61: params.setFiltered(SessionUtils.isFiltered()); why this is not in getBackendCollection()? it would solve this in generic way... .................................................... File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDataCenterResource.java Line 40: params.setFiltered(SessionUtils.isFiltered()); why this is not in performGet()? it would solve this in generic way... -- To view, visit http://gerrit.ovirt.org/4367 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I563d7e139d739eb0c9327abdd4167b945cb28931 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Asaf Shakarchi <[email protected]> Gerrit-Reviewer: Michael Pasternak <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
