Sergey Gotliv has uploaded a new change for review.

Change subject: webadmin: Fix validate() in EditDiskModel
......................................................................

webadmin: Fix validate() in EditDiskModel

EditDiskModel validate() called parent validate method but ignored
its results.

Change-Id: I5df677f42b76b07d489a698978f62bd5df02c415
Signed-off-by: Sergey Gotliv <[email protected]>
---
M 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/EditDiskModel.java
1 file changed, 1 insertion(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/59/23959/1

diff --git 
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/EditDiskModel.java
 
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/EditDiskModel.java
index 65293f0..e2ba125 100644
--- 
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/EditDiskModel.java
+++ 
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/EditDiskModel.java
@@ -129,12 +129,11 @@
 
     @Override
     public boolean validate() {
-        super.validate();
         getSizeExtend().validateEntity(new IValidation[] {
                 new NotEmptyValidation(),
                 new NonNegativeLongNumberValidation()
         });
-        return getSizeExtend().getIsValid();
+        return super.validate() && getSizeExtend().getIsValid();
     }
 
     private void disableNonChangeableEntities() {


-- 
To view, visit http://gerrit.ovirt.org/23959
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5df677f42b76b07d489a698978f62bd5df02c415
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to