Alon Bar-Lev has posted comments on this change. Change subject: tools: Support snmp trap as a notification method. ......................................................................
Patch Set 20: (2 comments) I do not see my code here... sorry, maybe I am confused with too much code. Please separate this patch to at least: 1. the configuration _xxx addition and its tests. 2. the filtering logic with my code, as it has nothing to do with snmp, and can be applied to smtp as well. 3. the snmp. Thanks! http://gerrit.ovirt.org/#/c/22909/20/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/LocalConfig.java File backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/LocalConfig.java: if you added tests and such for this change, please separate it to different patch along with its tests, so we have only snmp related changes in this patch. Line 1: package org.ovirt.engine.core.utils; Line 2: Line 3: import java.io.BufferedReader; Line 4: import java.io.File; Line 280: * allowMissing is false. Line 281: */ Line 282: public String getProperty(String key, String optionalSuffix, boolean allowMissing) { Line 283: String property = getProperty(key + "_" + optionalSuffix, true); Line 284: if (property == null || StringUtils.isBlank(property)) { isBlank takes null into account, if not use isEmpty or any other StringUtils method, this is why these were introduced. Line 285: property = getProperty(key, allowMissing); Line 286: } Line 287: return property; Line 288: } -- To view, visit http://gerrit.ovirt.org/22909 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0cd22d022ae535f45e046b09a2cbfadd837b465c Gerrit-PatchSet: 20 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Liran Zelkha <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
