Liran Zelkha has uploaded a new change for review.

Change subject: core: When ActivateVDS fails, move VDS out of Unassigned status
......................................................................

core: When ActivateVDS fails, move VDS out of Unassigned status

If ActivateVDS command fails, in some rare scenarios the VDS will be
stuck on Unassigned status, locking any ability to remove/activate the
VDS. This patch will move failed VDS to Error status.

Change-Id: I776fb9fd0fe3292ad257c7bcfaf4ac8c89536869
Bug-Url: https://bugzilla.redhat.com/962180
Signed-off-by: [email protected] <[email protected]>
---
M 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ActivateVdsCommand.java
1 file changed, 4 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/45/24045/1

diff --git 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ActivateVdsCommand.java
 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ActivateVdsCommand.java
index bb15e13..ac25c94 100644
--- 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ActivateVdsCommand.java
+++ 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ActivateVdsCommand.java
@@ -67,6 +67,10 @@
                         return null;
                     }
                 });
+            } else {
+                // We didn't manage to activate host. Set its status to Error
+                runVdsCommand(VDSCommandType.SetVdsStatus,
+                        new SetVdsStatusVDSCommandParameters(getVdsId(), 
VDSStatus.Error));
             }
         }
 


-- 
To view, visit http://gerrit.ovirt.org/24045
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I776fb9fd0fe3292ad257c7bcfaf4ac8c89536869
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liran Zelkha <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to