Vered Volansky has uploaded a new change for review. Change subject: core: Fix faulty CDA in AddVmAndCloneImageCommand ......................................................................
core: Fix faulty CDA in AddVmAndCloneImageCommand In case super returned true, CDA returned true with no regard to what happens in the for loop. This patch aims to implement to author's original intention while using early return. Change-Id: Ib4e63bf719a9bc98145a6401b05ed47005655486 Signed-off-by: Vered Volansky <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmAndCloneImageCommand.java 1 file changed, 4 insertions(+), 6 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/51/24051/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmAndCloneImageCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmAndCloneImageCommand.java index a337d7c..545db0e 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmAndCloneImageCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmAndCloneImageCommand.java @@ -123,17 +123,15 @@ @Override protected boolean canDoAction() { - boolean retValue = false; if (super.canDoAction()) { for (DiskImage diskImage : getDiskImagesToBeCloned()) { - retValue = checkImageConfiguration(diskImage); - if (!retValue) { - break; + if (!checkImageConfiguration(diskImage)){ + return false; } } - retValue = true; + return true; } - return retValue; + return false; } protected abstract boolean checkImageConfiguration(DiskImage diskImage); -- To view, visit http://gerrit.ovirt.org/24051 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib4e63bf719a9bc98145a6401b05ed47005655486 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
