Daniel Erez has posted comments on this change. Change subject: webadmin: Confirmation window when putting storage domain on maintenance ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/24023/2/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageDataCenterListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageDataCenterListModel.java: Line 553: model.setMessage(ConstantsManager.getInstance().getConstants().areYouSureYouWantToPlaceFollowingStorageDomainsIntoMaintenanceModeMsg()); Line 554: model.setHashName("maintenance_storage_domain"); //$NON-NLS-1$ Line 555: setWindow(model); Line 556: Line 557: model.getLatch().setEntity(false); do we need a latch in the dialog? Line 558: Line 559: ArrayList<String> items = new ArrayList<String>(); Line 560: for (Object selected : getSelectedItems()) { Line 561: items.add(((StorageDomain) selected).getName()); -- To view, visit http://gerrit.ovirt.org/24023 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If6c673291b4a1fc2610b99710cdcdfab11ad9bd4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
